Re: [PATCH] Input: fixed EVIOCGRAB iterative grab/release.

[Dmitry Torokhov]

On Thu, Feb 10, 2011 at 03:42:50PM -0800, tlambert@xxxxxxxxxxxx wrote:
> From: Terry Lambert <tlambert@xxxxxxxxxxxx>
> 
> Fixed order of calls in evdev_ungrab to allow iterative use of
> code which grabs and releases input event devices.
> 

Sorry, could you  please be more verbose?

> Signed-off-by: Terry Lambert <tlambert@xxxxxxxxxxxx>
> ---
>  drivers/input/evdev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
> index c8471a2..0bac8da 100644
> --- a/drivers/input/evdev.c
> +++ b/drivers/input/evdev.c
> @@ -160,9 +160,9 @@ static int evdev_ungrab(struct evdev *evdev, struct evdev_client *client)
>  	if (evdev->grab != client)
>  		return  -EINVAL;
>  
> +	input_release_device(&evdev->handle);
>  	rcu_assign_pointer(evdev->grab, NULL);
>  	synchronize_rcu();
> -	input_release_device(&evdev->handle);
>  
>  	return 0;
>  }
> -- 
> 1.7.3.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/