Re: netfilter is not a filesystem

[Patrick McHardy]

Am 10.02.2011 23:11, schrieb Andrew Morton:
> On Thu, 10 Feb 2011 21:55:26 GMT
> bugzilla-daemon@xxxxxxxxxxxxxxxxxxx wrote:
> 
>> https://bugzilla.kernel.org/show_bug.cgi?id=28862
>>
>>            Summary: /proc/net/ip_conntrack: no space left on device
>>                     systematically
> 
> This is why I'm forever nagging people to not just grab some errno
> because its name happens to sound similar to the error you just detected.
> 
> Yes, it superficially seems nice and logical for netfilter to use
> ENOSPC when it runs out of space.  But when that error code propagates
> up to the user, they see "no space left on device" and will then run
> "df" and wonder what the hell happened to their computer.
> 

In this case this seems to be a simple bug, the seq_file callbacks
want to indicate that the current buffer is full, using an incorrect
code. I'm not sure why ENOSPC is used, this probably has never worked
(and strangely nobody seems to have noticed).

This bug is probably present in more parts of netfilter, I'll do an
audit and fix up all similar problems.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/