Re: b44 driver causes panic when using swiotlb

[Chuck Ebbert]

On Mon, 14 Feb 2011 20:59:43 +0900
FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote:

> > Can you try this? b44 has the own bouncing mechanism so if swiotlb
> > returns an error, the driver can allocate an appropriate buffer.
> > 
> > diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> > index c47bbe1..93ca08b 100644
> > --- a/lib/swiotlb.c
> > +++ b/lib/swiotlb.c
> > @@ -686,8 +686,10 @@ dma_addr_t swiotlb_map_page(struct device *dev, struct page *page,
> >  	/*
> >  	 * Ensure that the address returned is DMA'ble
> >  	 */
> > -	if (!dma_capable(dev, dev_addr, size))
> > -		panic("map_single: bounce buffer is not DMA'ble");
> > +	if (!dma_capable(dev, dev_addr, size)) {
> > +		swiotlb_tbl_unmap_single(dev, map, size, dir);
> > +		dev_addr = swiotlb_virt_to_bus(dev, io_tlb_overflow_buffer);
> > +	}
> >  
> >  	return dev_addr;
> >  }
> 
> Ping, any chance to try this?

The user who reported the bug tried it and says that it works.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/