Re: [PATCH] staging: rts_pstor: fix sparse warning

From: Greg KH
Date: Tue Feb 15 2011 - 21:10:45 EST


On Wed, Feb 16, 2011 at 09:43:38AM +0800, wei_wang@xxxxxxxxxxxxxx wrote:
> From: wwang <wei_wang@xxxxxxxxxxxxxx>
>
> Add static modifier before some function definitions; delete function
> named rtsx_transfer_sglist which won't be called.

Thanks for describing this better.

And now that we can easily see that you are doing more than one thing in
this patch, please redo it, only doing one-thing-per-patch as is the way
we require patches to be.

Care to resend this as a series of patches?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/