On Mon, Feb 14, 2011 at 10:30:10AM +0800, Thomas Chou wrote:From: Albert Herranz<albert_herranz@xxxxxxxx>
This patch adds devicetree support to i2c-gpio driver. The allocation
of local data is integrated to a private structure, and use devm_*
helper for easy cleanup.
It is base on an earlier patch for gc-linux from
Albert Herranz<albert_herranz@xxxxxxxx>.
Signed-off-by: Thomas Chou<thomas@xxxxxxxxxxxxx>
CC: Albert Herranz<albert_herranz@xxxxxxxx>
Acked-by: Haavard Skinnemoen<hskinnemoen@xxxxxxxxx>
One minor nitpick below, but I'd be fine with cleaning that up via a
followup patch. This one looks correct to me.
Acked-by: Grant Likely<grant.likely@xxxxxxxxxxxx>
Ben, this one depends on a patch in my devicetree/next tree. How do
you want to handle it?
g.
+#ifdef CONFIG_OF
+#include<linux/of_gpio.h>
Instead of putting the include here, please add #ifdef CONFIG_OF
protection around the contents of linux/of_gpio.h itself. I fully
support that change so that includes can remain at the top where they
belong.