Re: [PATCHv2 10/11] unicore32 core architecture: interrupts ang gpiohandling

[Thomas Gleixner]

On Sun, 13 Feb 2011, Guan Xuetao wrote:
> +
> +#ifndef __ASSEMBLY__
> +struct irqaction;

Why do you need that ?

> +struct pt_regs;
> +extern void migrate_irqs(void);

What's that for ? Used nowhere AFAICT

> +extern void asm_do_IRQ(unsigned int, struct pt_regs *);
> +
> +#endif

> +static struct irq_chip puv3_low_gpio_chip = {
> +	.name		= "GPIO-low",
> +	.ack		= puv3_low_gpio_ack,

Please use irq_* functions. These are deprecated and going away soon.

> +	.mask		= puv3_low_gpio_mask,
> +	.unmask		= puv3_low_gpio_unmask,
> +	.set_type	= puv3_gpio_type,
> +	.set_wake	= puv3_low_gpio_wake,
> +};
> +
> +static struct irq_chip puv3_normal_chip = {
> +	.name		= "PKUnity-v3",
> +	.ack		= puv3_mask_irq,
> +	.mask		= puv3_mask_irq,
> +	.unmask		= puv3_unmask_irq,
> +	.set_wake	= puv3_set_wake,
> +};

  Ditto

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/