Re: [sodaville] [PATCH TIP 02/14] x86: Add device tree support

[Grant Likely]

On Thu, Feb 17, 2011 at 4:31 AM, Sebastian Andrzej Siewior
<bigeasy@xxxxxxxxxxxxx> wrote:
> * Grant Likely | 2011-02-16 14:31:26 [-0700]:
>
>>> +config X86_OF
>>> +    bool "Support for device tree"
>>> +    select OF
>>> +    select OF_EARLY_FLATTREE
>>> +    ---help---
>>> +      Device tree support on X86.
>>> +
>>
>>On ARM and MIPS, this is called 'config USE_OF'.  It would be nice to have
>>some commonality.  Maybe I should move the user-visible option to
>>drivers/of/Kconfig.  Or perhaps I should just make CONFIG_OF itself
>>user visible.
>>
>>thoughts?
>
> We could make CONFIG_OF depend on CONFIG_HAVE_OF_SUPPORT and let OF
> select OF_EARLY_FLATTREE if ARCH_WANT_EARLY_FLATTREE for instance. So
> that part would work in a generic way.
>
> For OF-only platforms you would have to go to drivers/of
> before you can enable the specific SoC/board. So it could lead to
> something like "first enable scsi disk before you can enable usb
> storage".

That's definitely not desirable.  Currently ARM and MIPS boards that
need it are force-selecting USE_OF which pretty much solves the
problem.  The option is always user-
>
> I like it :) For now I rename to USE_OF.

okay.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/