Re: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros

[Jamie Iles]

On Thu, Feb 17, 2011 at 05:37:47PM -0700, John Linn wrote:
> > > +static inline void arch_reset(char mode, const char *cmd)
> > > +{
> > > +	/* Add architecture specific reset processing here */
> > 
> > I think you can add cpu_reset(0) in here to try a soft reset by
> jumping
> > to the reset vector.  This should give you some reset functionality.
> 
> Hi Jamie,
> 
> How strongly do you feel that this has to be in on this initial patch
> set?
> 
> There will be many more coming later and I'd like to postpone that one
> as it's really additional
> functionality vs a bug (to me anyway).

I don't have a strong opinion on it.  If you leave it as it is so that 
arch_reset() will return then the generic ARM code will issue a printk 
to tell the user that it failed then drop into an infinite loop so it 
should be obvious that reset isn't implemented!

If reset is nontrivial then you're probably right to leave it out of 
this patch and put it into another later on.

Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/