RE: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros
From: John Linn
Date: Fri Feb 18 2011 - 09:28:20 EST
> -----Original Message-----
> From: John Linn
> Sent: Friday, February 18, 2011 7:00 AM
> To: 'Jamie Iles'
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
linux-kernel@xxxxxxxxxxxxxxx; linux@xxxxxxxxxxxxxxxx;
> catalin.marinas@xxxxxxx; glikely@xxxxxxxxxxxx; arnd@xxxxxxxx
> Subject: RE: [PATCH V3 3/4] ARM: Xilinx: base header files and
assembly macros
>
> > -----Original Message-----
> > From: Jamie Iles [mailto:jamie@xxxxxxxxxxxxx]
> > Sent: Friday, February 18, 2011 2:06 AM
> > To: John Linn
> > Cc: Jamie Iles; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
linux-kernel@xxxxxxxxxxxxxxx;
> > linux@xxxxxxxxxxxxxxxx; catalin.marinas@xxxxxxx;
glikely@xxxxxxxxxxxx; arnd@xxxxxxxx
> > Subject: Re: [PATCH V3 3/4] ARM: Xilinx: base header files and
assembly macros
> >
> > On Thu, Feb 17, 2011 at 06:19:09PM -0700, John Linn wrote:
> > > > > +#define PHYS_OFFSET 0x0
> > > >
> > > > This should be PLAT_PHYS_OFFSET and could do with being
surrounded
> > > with
> > > > UL() e.g.
> > > >
> > > > #define PLAT_PHYS_OFFSET UL(0x00000000)
> > >
> > > This doesn't build with 2.6.38-rc5, am I missing something?
> > >
> > > PHYS_OFFSET is still needed from what I can tell, but maybe I
overlooked
> > > something.
> >
> > The change is queued up in Russell's devel branch for the dynamic
p2v
> > and will be in 2.6.39. For a patch series like this it's probably
worth
> > developing off of linux-next[1]. This contains all of the trees
that
> > will be mereged into the next kernel so carries the bigger changes
like
> > dynamic p2v.
>
> My hope was to get into 2.6.38 and maybe that was not realistic. If
it's too late
> for 2.6.38 then I'll revise the patch for this branch.
I guess it was too early and I wasn't thinking clearly there with
2.6.38.
You were right on 2.6.39. Sounds like I should switch to this other
branch
to develop against.
Thanks,
John
>
> Any thoughts Russell based on where we are?
>
> Thanks for the insight.
> John
>
> >
> > Jamie
> >
> > 1. git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/