Re: linux-next: build warnings after merge of the i2c tree

[Stephen Rothwell]

Hi Jean,

On Mon, 21 Feb 2011 10:58:58 +0100 Jean Delvare <khali@xxxxxxxxxxxx> wrote:
>
> On Mon, 21 Feb 2011 15:35:22 +1100, Stephen Rothwell wrote:
> > Hi Jean,
> > 
> > After merging the tip tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced these warnings:
> > 
> > drivers/i2c/i2c-core.c: In function 'i2c_do_add_adapter':
> > drivers/i2c/i2c-core.c:799: warning: 'attach_adapter' is deprecated (declared at include/linux/i2c.h:149)
> > drivers/i2c/i2c-core.c:804: warning: 'attach_adapter' is deprecated (declared at include/linux/i2c.h:149)
> > drivers/i2c/i2c-core.c: In function 'i2c_do_del_adapter':
> > drivers/i2c/i2c-core.c:985: warning: 'detach_adapter' is deprecated (declared at include/linux/i2c.h:150)
> > drivers/i2c/i2c-core.c:988: warning: 'detach_adapter' is deprecated (declared at include/linux/i2c.h:150)
> > 
> > Introduced by commit 95529c656b97b08c7a92504f98650a229f03ae04 ("i2c:
> > Deprecate i2c_driver.attach_adapter and .detach_adapter").  We normally
> > fix up as many uses of an interface as possible before deprecating it ...
> 
> These are the core locations where the deprecated callbacks are called.
> Ideally they would _not_ emit warnings, are these are legitimate and
> can't be removed before all drivers relying on these callbacks have
> been fixed. If there is a way to silent these warnings, please let me
> know, as I don't know of any.

You could build just that file with -Wno-deprecated-declarations, or put
the deprecated stuff into another file that is built with that flag.
We did the latter with pci_find_device (see commit e8b553bf4b19c "PCI:
disable pci_find_device warnings when deprecated pci functions are
enabled").

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature