Re: [PATCH] gpio: Fix wrong pointer type in pca953x

[Dan Carpenter]

On Tue, Feb 22, 2011 at 09:56:50AM +0100, Dirk Eibach wrote:
>  	struct pca953x_platform_data *pdata;
>  	struct device_node *node;
> -	const uint16_t *val;
> +	const u32 *val;
>  

This should probably be signed?  We compare it against zero later on.

                if (*val < 0)
                        dev_warn(&client->dev,
                                 "invalid gpio-base in device tree\n");

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/