Re: linux-next: build failure after merge of the v9fs tree

[Eric Van Hensbergen]

JV - you should be able to check this just by building with allmod
config.  I'll accept a pull immediately if this is the fix.

        -eric


On Tue, Feb 22, 2011 at 12:22 AM, Venkateswararao Jujjuri (JV)
<jvrao@xxxxxxxxxxxxxxxxxx> wrote:
> On 2/21/2011 9:30 PM, Stephen Rothwell wrote:
>> Hi,
>>
>> On Mon, 21 Feb 2011 21:20:31 -0800 "Venkateswararao Jujjuri (JV)" <jvrao@xxxxxxxxxxxxxxxxxx> wrote:
>>>
>>> On 2/21/2011 4:53 PM, Stephen Rothwell wrote:
>>>>
>>>> After merging the v9fs tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> ERROR: "p9_payload_gup" [net/9p/9pnet_virtio.ko] undefined!
>>>> ERROR: "p9_nr_pages" [net/9p/9pnet_virtio.ko] undefined!
>>>> ERROR: "p9_release_req_pages" [net/9p/9pnet_virtio.ko] undefined!
>>>
>>> These functions are defined by commit 249951bf66816128a7698caa826425e299494c82
>>> ([net/9p] Preparation and helper functions for zero copy)
>>
>> Yes, they are - but they are not exported to modules.
>
> Thanks; Can you please check if this patch fixes your issue?
>
> diff --git a/net/9p/trans_common.c b/net/9p/trans_common.c
> index ca705f1..da7c2cd 100644
> --- a/net/9p/trans_common.c
> +++ b/net/9p/trans_common.c
> @@ -13,6 +13,7 @@
>  */
>
>  #include <linux/slab.h>
> + #include <linux/module.h>
>  #include <net/9p/9p.h>
>  #include <net/9p/client.h>
>  #include <linux/scatterlist.h>
> @@ -32,6 +33,7 @@ p9_release_req_pages(struct trans_rpage_info *rpinfo)
>                i++;
>        }
>  }
> +EXPORT_SYMBOL(p9_release_req_pages);
>
>  /**
>  * p9_nr_pages - Return number of pages needed to accomodate the payload.
> @@ -45,6 +47,7 @@ p9_nr_pages(struct p9_req_t *req)
>                        PAGE_SIZE - 1) >> PAGE_SHIFT;
>        return end_page - start_page;
>  }
> +EXPORT_SYMBOL(p9_nr_pages);
>
>  /**
>  * payload_gup - Translates user buffer into kernel pages and
> @@ -91,3 +94,4 @@ p9_payload_gup(struct p9_req_t *req, size_t *pdata_off, int *p
>        }
>        return 0;
>  }
> +EXPORT_SYMBOL(p9_payload_gup);
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/