Re: [PATCH 1/2] staging: remove null checks before kfree

From: Greg KH
Date: Tue Feb 22 2011 - 09:59:57 EST


On Tue, Feb 22, 2011 at 03:53:40AM -0500, Ilia Mirkin wrote:
> This patch was created with the following semantic patch:
>
> // <smpl>
> @@
> expression E;
> @@
>
> - if (E != NULL) kfree(E);
> + kfree(E);
> // </smpl>
>
> Signed-off-by: Ilia Mirkin <imirkin@xxxxxxxxxxxx>
> ---
>
> Hi Greg,
>
> Please let me know if you would rather I split these up by driver instead.
> I didn't because I saw that you took staging-wide cleanups before.

Please split these up per-driver, it makes it easier to merge and for
the individual driver authors to review them.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/