Re: [PATCH] msm: add single-wire serial bus interface (SSBI) driver
From: Daniel Walker
Date: Tue Feb 22 2011 - 19:39:36 EST
On Tue, 2011-02-22 at 16:17 -0800, David Brown wrote:
> On Tue, Feb 22 2011, Daniel Walker wrote:
>
> > On Tue, 2011-02-22 at 12:47 -0800, Dima Zavin wrote:
> >
> >> What is the problem leaving it under arch/arm/mach-msm?
> >
> > Because it's a driver.
>
> There are a lot of other drivers currently under various arch
> subsystems. I'm not sure if a driver that is specific to only one arch
> has a strong reason to be elsewhere in the kernel. If there was a
> possibility of there being other devices that used SSBI, it might make
> sense to put it elsewhere. But, as far as I know, this device is only
> found on MSM chips.
There are lots of arch specific drivers under drivers/ . In fact I'm
sure there are more arch specific drivers under drivers/ than anyplace
else. That's how we organize things in Linux.
> It seems kind of unusual to create an entirely new directory under
> drivers to hold what will only ever be a single driver.
Then put it under another directory.
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/