Re: [PATCH RFC tip/core/rcu 11/11] rcu: move TREE_RCU from softirqto kthread

[Steven Rostedt]

On Wed, 2011-02-23 at 09:02 -0500, Mathieu Desnoyers wrote:
> * Paul E. McKenney (paulmck@xxxxxxxxxxxxxxxxxx) wrote:
> [...]
> > +	for (cpu = rnp->grplo; cpu <= rnp->grphi; cpu++, mask <<= 1)
> > +		if (mask & 01)
> 
> Wow, octal notation! ;)

Heh

> 
> Maybe we could consider 0x1 here.

Why even the conversion? mask & 1 should be good enough.

Perhaps 1UL to match the unsigned long.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/