Re: btusb autosuspend (was Re: Linux 2.6.38-rc6)

From: Matthew Garrett
Date: Wed Feb 23 2011 - 19:43:59 EST


On Wed, Feb 23, 2011 at 04:25:23PM -0800, Linus Torvalds wrote:
> Hmm. Is there any reason we shouldn't revert commit
> 556ea928f78a390fe16ae584e6433dff304d3014 given the regression?

I think reverting makes sense at the moment. I haven't seen the reported
issues - I need to figure out if this is related to bus powered/self
powered devices, or what else is causing the difference.

> It apparently had problems before too, and caused autosuspend to be
> disabled entirely, judging at least by
>
> https://bugzilla.redhat.com/show_bug.cgi?id=528744
>
> but there's obviously the comment about "those should be fixed now".
> Apparently there are more issues.

Right, we were autosuspending even when there were active connections.
Marcel told me that ought to be fixed and my testing seemed to agree...

> I have no idea whether this is a USB-level issue, or a driver-level
> one. There are no comments about exactly what fixed the input device
> issues. So I'm adding both BT and USB people to the discussion.

I'll try to get time to look at this this week. Marcel, any ideas?

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/