Re: [PATCH 1/2] perf: Fix the software events state check

[Ingo Molnar]

* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> Fix the mistakenly inverted check of events state.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Stephane Eranian <eranian@xxxxxxxxxx>
> ---
>  kernel/perf_event.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> index ed253aa..974e2e6 100644
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -5122,7 +5122,7 @@ static int perf_exclude_event(struct perf_event *event,
>  			      struct pt_regs *regs)
>  {
>  	if (event->hw.state & PERF_HES_STOPPED)
> -		return 0;
> +		return 1;

Just wondering, what was/is the practical effect of this bug, and how far back does 
it go (any need for a -stable tag)?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/