Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues

[Vinay Sawal]

On Wed, Mar 9, 2011 at 1:26 PM, Greg KH <gregkh@xxxxxxx> wrote:
> On Wed, Mar 09, 2011 at 12:50:01PM -0800, Vinay Sawal wrote:
>> Fixed all issues reported by checkpatch script on this file.
>>
>> Signed-off-by: Vinay Sawal <vinaysawal@xxxxxxxxx>
>> ---
>>  drivers/staging/bcm/Bcmnet.c |   51 +++++++++++++++++++++++++++++------------
>>  1 files changed, 36 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c
>> index a6ce239..4e38a76 100644
>> --- a/drivers/staging/bcm/Bcmnet.c
>> +++ b/drivers/staging/bcm/Bcmnet.c
>> @@ -1,3 +1,23 @@
>> +/*
>> +    bcm/Bcmnet.c
>> +    Bcm network driver
>> +
>> +    This program is free software; you can redistribute it and/or modify
>> +    it under the terms of the GNU General Public License as published by
>> +    the Free Software Foundation; either version 2 of the License, or
>> +    (at your option) any later version.
>
> Why "or any later version"?  Are you allowed to relicense the code here?
>
>> +
>> +    This program is distributed in the hope that it will be useful,
>> +    but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +    GNU General Public License for more details.
>> +
>> +    You should have received a copy of the GNU General Public License
>> +    along with this program; if not, write to the Free Software
>> +    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>
> Are you willing to track the office movements of the FSF for the next 40
> years and send patches updating the address?  If not, NEVER, include
> this paragraph, it's pointless.
>
> Anyway, as others stated, this is not acceptable for a "fix checkpatch
> warnings" type of patch, please redo it.

Fair point. I'll re-generate the patch.

thanks,
vinay

>
> thanks,
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/