Re: [Xen-devel] [PATCH 06/14] xen: events: refactor GSI pirqbindings functions

From: Ian Campbell
Date: Thu Mar 10 2011 - 03:37:26 EST


On Thu, 2011-03-10 at 04:00 +0000, Konrad Rzeszutek Wilk wrote:
> if (0 == nr_ioapics) {
> > - for (irq = 0; irq < NR_IRQS_LEGACY; irq++)
> > - xen_allocate_pirq(irq, 0, "xt-pic");
> > + for (irq = 0; irq < NR_IRQS_LEGACY; irq++) {
> > + pirq = xen_allocate_pirq_gsi(irq);
> > + if (pirq < 0)
> > + break;
>
> Would it make sense to print a warning here?

I was almost tempted by a BUG_ON but:

8<-------------------------------------------------