Re: RFC: x86: kill binutils 2.16.x?

[Ingo Molnar]

* Michal Marek <mmarek@xxxxxxx> wrote:

> On 3.3.2011 09:30, Ingo Molnar wrote:
> > * H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> >> kbuild people: is there a way to test for a specific assembler version
> >> in Kbuild (and error out the build for it?)
> > 
> > Could we add a testcase for one of the more egregious breakages and bail out then? 
> > That way we don't have to get the version information right - broken prereleases 
> > would be covered as well.
> > 
> > For example this sequence:
> > 
> > .irp idx,0,1,2
> > .if 0 > \idx
> > .endif
> > .endr
> >
> > Will break on 2.16, right? It builds fine on 2.20.
> 
> This seems to work for me with the binutils version from sles10 (even
> with a vanilla build of binutils):
> $ as -v <<EOF; echo $?
> > .irp idx,0,1,2
> > .if 0 > \idx
> > .endif
> > .endr
> > EOF
> GNU assembler version 2.16.91.0.5 (i586-suse-linux) using BFD version
> 2.16.91.0.5 20051219
> 0
> $
> 
> So either the bug is fixed in that version already or you picked a wrong
> example (or I did not understand what should fail here). But don't get
> me wrong, I'm all for checking for actual bugs instead of innocent
> version strings.

I cited an incorrect testcase most likely. Note that Jan was able to work around the 
limitations in 2.16 after all - see the workaround commit that i have queued up in 
x86/mm, attached below.

Thanks,

	Ingo

--------------->