Re: [PATCH 0/2] jump label: update for .39

From: Steven Rostedt
Date: Thu Mar 10 2011 - 16:34:27 EST


On Thu, 2011-03-10 at 16:14 -0500, Mathieu Desnoyers wrote:

> > Just insert a long "Reserved" word.
>
> I agree that this solution can work, but it's only because the
> "object" definition is done in assembly in this case (and not in C, like
> we did for trace event and tracepoints). Padding to power of 2 multiples
> should make the linker happy. There should be a nice comment beside
> these padding elements though.

Rereading what David and even what you wrote just now, I don't think
this is even needed. As you said. The issue with us is that we had
defined structs in C as static which lost all bets. Not to mention,
these structures were not natural word aligned.

The linker should not be adding holes more than natural word alignment.
Why waste space?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/