Re: [PATCH 12/21] Staging: hv: Cleanup irq management

[Hank Janssen]

On Mar 10, 2011, at 14:46, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx> wrote:
>> 
> 
>>    }
>> -    vector = VMBUS_IRQ_VECTOR;
>> 
>> -    DPRINT_INFO(VMBUS_DRV, "irq 0x%x vector 0x%x", vmbus_irq, vector);
>> +    vector = IRQ0_VECTOR + pdev->irq;
>> +    DPRINT_INFO(VMBUS_DRV, "irq 0x%x vector 0x%x", pdev->irq,
>> +            IRQ0_VECTOR + pdev->irq);
> 
> Why evaluating vector first and then not using it for that debug print
> thingy?
> 
> Btw, are you going to replace that DPRINT_* stuff as well ?
> 
> Thanks,
> 
>     

Yes, that is in my next set of patches. 

Hank
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/