Re: isci for 2.6.39?

[Dan Williams]

On Thu, 2011-03-10 at 16:10 -0800, James Bottomley wrote:
> On Thu, 2011-03-10 at 16:02 -0800, Dan Williams wrote:
> > Given the impending opening of the 2.6.39 merge window I would like to
> > discuss the options for merging the isci driver.  Review has been
> > intermittent which is understandable given the size and flux of the
> > codebase.  It has received a good amount of cleanups, but additional
> > review issues and cleanups are still all too easy to spot.  I know you
> > have expressed reservations about taking scsi drivers through -staging
> > in the past [1], so I would like to propose an alternative.  Merge the
> > driver into scsi-misc but with a -staging style TODO file that tracks
> > the review issues.  If the TODO file is not addressed by the 2.6.40
> > window the driver would be moved to -staging.  This has the benefit of
> > keeping the driver under your purview and expected location, but still
> > have the imminent prospect of being de-staged to ensure the community's
> > concerns are ultimately addressed.  We fully intend to maintain the
> > current momentum on the driver cleanup effort and be ready in advance of
> > 2.6.40.
> 
> Given that you only posted the core files today, I think it's a bit late
> for the 2.6.39 merge window, which will be opening in under a week.

The core has been available for review via the git tree for a month.  We
waited to roll out the core in patch form to be considerate of people's
review bandwidth and to get focus on the lldd portion while additional
cleanups were applied to the core.

> You could send it all to staging ... it's just that pretty much seems to
> guarantee no SCSI review, which is what you seem to need at the moment.

Right, hence the proposal for provisional acceptance into scsi-misc.
Either way there will be a TODO file with issues to address by 2.6.40.
I realize this is unprecedented, but I believe you can derive the team's
ability and willingness to cleanup the driver from the git history [1]
(Note the Reported-by tags for all the review comments received to
date).

If the team gets hit by a bus and stops making cleanups we can always
de-stage the driver.

As a matter of process do you ever take git pull requests, or only
patches?

> > As a side note I'm still looking for a disposition for:
> > "libsas: flush initial device discovery before completing ->scan_finished()" [2]
> > "libsas: fix/amend device gone notification in sas_deform_port()" [3]
> 
> I thought I commented ... I'll go back and dig them out of email.

You did comment on the sas_flush_discovery() one, and I found that
flush_workqueue does not account for new work queued as a result of the
flush.

--
Dan

[1]: git://git.kernel.org/pub/scm/linux/kernel/git/djbw/isci.git

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/