Re: [PATCH 0/2] jump label: update for .39

[Michael Ellerman]

On Fri, 2011-03-11 at 01:38 +0100, Ralf Baechle wrote:
> On Thu, Mar 10, 2011 at 04:22:14PM -0500, Mathieu Desnoyers wrote:
> 
> > You seem to be contradicting yourself here. I'm concerned about having
> > "structures" of a size not power of two. Can we simply either
> > 
> > - Add a padding element at the end
> > or
> > - use .align 4*sizeof(long) at the beginning
> > 
> > to make sure the linker won't put any holes when it puts objects 
> > together ?
> 
> It may only be a technicality but but careful with .align.  On some
> architectures .align x will align to a multiple of x; on other
> architectures to 2^x.  Another reason to stick to C wherever possible.

.balign is saner:

http://sourceware.org/binutils/docs-2.21/as/Balign.html

cheers

Attachment: signature.asc
Description: This is a digitally signed message part