Re: [PATCH 1/2] hid: ntrig NO_INIT_REPORTS

[Peter Hutterer]

On Wed, Mar 09, 2011 at 11:33:51PM -0500, Rafi Rubin wrote:
> Probing reports does bad things with some ntrig firmwares, better to
> just leave them alone.
> 
> Signed-off-by: Rafi Rubin <rafi@xxxxxxxxxxxxxx>
> 
> ---
> 
> This resolves an annoying delay on initialization and reduces the
> chance of the device coming up in an odd state or crashing.

never saw those delays but this patch doesn't make anything worse for me.

Tested-by: Peter Hutterer <peter.hutterer@xxxxxxxxx>

Cheers,
  Peter

> ---
>  drivers/hid/hid-ntrig.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
> index b1e9cca..850ba14 100644
> --- a/drivers/hid/hid-ntrig.c
> +++ b/drivers/hid/hid-ntrig.c
> @@ -837,7 +837,8 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)
>  	struct hid_report *report;
>  
>  	if (id->driver_data)
> -		hdev->quirks |= HID_QUIRK_MULTI_INPUT;
> +		hdev->quirks |= HID_QUIRK_MULTI_INPUT
> +				| HID_QUIRK_NO_INIT_REPORTS;
>  
>  	nd = kmalloc(sizeof(struct ntrig_data), GFP_KERNEL);
>  	if (!nd) {
> -- 
> 1.7.4.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/