Re: [PATCH 21/22] staging: xgifb: rename XGINew_SetRegANDOR() toxgifb_reg_and_or()

[Aaro Koskinen]

Hi,

On Sat, 12 Mar 2011, Dan Carpenter wrote:
> On Thu, Mar 10, 2011 at 11:02:46PM +0200, Aaro Koskinen wrote:
> > Rename XGINew_SetRegANDOR() to xgifb_reg_and_or().
> >
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> > ---
>
> > -void XGINew_SetRegANDOR(unsigned long Port, unsigned short Index,
> > -		unsigned short DataAND, unsigned short DataOR)
> > +void xgifb_reg_and_or(unsigned long port, u8 index, unsigned data_and,
>                                             ^^^^^^^^  ^^^^^^^^^^^^^^^^^
> > +		      unsigned data_or)
>                      ^^^^^^^^^^^^^^^^
> I wish the change log had mentioned some of these data type changes.  It
> doesn't cause a bug, but it still should have been mentioned.

Yes, you are right. Those cleanups were actually ment to be in a separate
patch. I will redo the patches.

Thanks,

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/