Re: [RFC PATCH 1/4] PLATFORM: introduce structure to bind asyncplatform data to a dev path name

[Greg KH]

On Sat, Mar 12, 2011 at 11:39:15PM +0000, Andy Green wrote:
> On 03/12/2011 11:29 PM, Somebody in the thread at some point said:
> 
> Hi -
> 
> >On Saturday, March 12, 2011, Andy Green wrote:
> >>This structure allows tagging arbitrary platform_data that can't be attached
> >>to a device until after it is probed, with the device path name that it is
> >>to be attached to.
> 
> >>+struct platform_async_platform_data {
> >>+	const char *device_path;
> >>+	void *platform_data;
> >>+};
> >>+
> >>  #endif /* _PLATFORM_DEVICE_H_ */
> >
> >Using device paths for this purpose seems to be very fragile to me.  Isn't
> >there any better solution?
> 
> Given that this targets board definition files which commonly do the
> platform_add_device for the USB bus controller synchronously, and
> the bus-connected devices it is aimed at are soldered on to the
> board connected to specific bus controllers, the bus paths are
> completely deterministic.

No they are not.

The physical layout is deterministic, but the bus number, and device
number, is not.  You are using the bus number here in this path, so that
is not going to work, sorry.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/