Re: [PATCH net-next-2.6] ftmac100: use GFP_ATOMIC allocations where needed

From: Po-Yu Chuang
Date: Mon Mar 14 2011 - 04:16:47 EST


Hi Eric,

On Mon, Mar 14, 2011 at 4:29 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Le dimanche 13 mars 2011 Ã 21:26 +0100, Eric Dumazet a Ãcrit :
>> Le dimanche 13 mars 2011 Ã 21:16 +0100, Eric Dumazet a Ãcrit :
>>
>> > BTW, it seems I missed the fact that ftmac100_alloc_rx_page() used a
>> > GFP_KERNEL allocation, while its called from softirq context (from
>> > ftmac100_rx_packet())
>>
>> Here is a patch against ftmac100
>>
>
> Oops, one typo in it sorry
>
>> -static int ftmac100_alloc_rx_page(struct ftmac100 *priv, struct ftmac100_rxdes *rxdes)
>> +static int ftmac100_alloc_rx_page(struct ftmac100 *priv,
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â struct ftmac100_rxdes *rxdes, gtp_t gfp)
>
> Should be : Â gfp_t gfp
>
> Please build and test the patch, I dont have an ARM testbed anyway.

Tested-by: Po-Yu Chuang <ratbert@xxxxxxxxxxxxxxxx>

Thank you,
Po-Yu Chuang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/