Re: [PATCH 1/2] MAX8997/8966 MFD: Add IRQ control feature

[MyungJoo Ham]

Hello Samuel,

On Mon, Mar 14, 2011 at 7:11 PM, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote:
>
> Hi MyungJoo,
>
> On Fri, Mar 04, 2011 at 04:45:47PM +0900, MyungJoo Ham wrote:
> > This patch enables IRQ handling for MAX8997/8966 chips.
> >
> > Signed-off-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Joe's comments make sense. Also, here are my comments:
>

Yes, in the patch series of MAX8997/8966 version 5, his comments are
applied at "[PATCH v5 3/4] MAX8997/8966 MFD: Add IRQ control feature".

[]

> All the (1 << n) parts could be nicely replaced with relevant #define. That
> would make your code more readable.

[]

> There are a lot of magic constants here, and I'd love to see that replaced as
> well with some more descriptive macros.
>

Thanks. I will post "PATCH v6" with some macros for the register bits.


> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/


Cheers!
 MyungJoo
--
MyungJoo Ham (íëì), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/