Re: [PATCH v2 12/12] driver: Google Memory Console

[Greg KH]

On Mon, Mar 14, 2011 at 03:23:15PM +0100, Ingo Molnar wrote:
> 
> * Tim Hockin <thockin@xxxxxxxxxx> wrote:
> 
> > This same BIOS logic is used across a number of Platforms.  We could
> > use something like the vendor strings to trigger this code off, [...]
> 
> Correct.
> 
> > [...] I suppose, but ick.  It's already in a google/ subdir and wrapped with 
> > CONFIG_GOOGLE_MEMCONSOLE.
> 
> That's not the point though - in this day and age we simply do not add non-generic 
> hacks like that - we've come a long way since the ISA days. The point is to make it 
> safe enough to limit its effects not just to CONFIG_GOOGLE_MEMCONSOLE but also to 
> affected hardware only.

I strongly agree, we can't take this as-is without this type of code
added to the driver, sorry.

Thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/