Re: [PATCH v2 2.6.38-rc8-tip 1/20] 1: mm: Move replace_page() tomm/memory.c

[Steven Rostedt]

On Mon, 2011-03-14 at 22:32 +0530, Srikar Dronamraju wrote:
> * Steven Rostedt <rostedt@xxxxxxxxxxx> [2011-03-14 10:16:35]:
> 
> > On Mon, 2011-03-14 at 19:04 +0530, Srikar Dronamraju wrote:
> > > User bkpt will use background page replacement approach to insert/delete
> > > breakpoints. Background page replacement approach is based on
> > > replace_page. Hence replace_page() loses its static attribute.
> > > 
> > 
> > Just a nitpick, but since replace_page() is being moved, could you
> > specify that in the change log. Something like:
> > 
> > "Hence, replace_page() is moved from ksm.c into memory.c and its static
> > attribute is removed."
> 
> Okay, Will take care to add the moved from ksm.c into memory.c in the
> next version of patchset.


Thanks!

> > I like to see in the change log "move x to y" when that is actually
> > done, because it is hard to see if anything actually changed when code
> > is moved. Ideally it is best to move code in one patch and make the
> 
> As discussed in IRC, moving and removing the static attribute had to
> be one patch so that mm/ksm.c compiles correctly. The other option we
> have is to remove the static attribute first and then moving the
> function.

Hmm, maybe that may be a good idea. Since it is really two changes. One
is to make it global for other usages. I'm not even sure why you moved
it. The change log for the move can explain that.

-- Steve

> 
> > change in another. If you do cut another version of this patch set,
> > could you do that. This alone is not enough to require a new release.
> > 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/