Re: [PATCH v2 2.6.38-rc8-tip 5/20] 5: Uprobes:register/unregister probes.

[Srikar Dronamraju]

* Steven Rostedt <rostedt@xxxxxxxxxxx> [2011-03-14 12:00:33]:

> On Mon, 2011-03-14 at 19:04 +0530, Srikar Dronamraju wrote:
> > +/* Returns 0 if it can install one probe */
> > +int register_uprobe(struct inode *inode, loff_t offset,
> > +                               struct uprobe_consumer *consumer)
> > +{
> > +       struct prio_tree_iter iter;
> > +       struct list_head tmp_list;
> > +       struct address_space *mapping;
> > +       struct mm_struct *mm, *tmpmm;
> > +       struct vm_area_struct *vma;
> > +       struct uprobe *uprobe;
> > +       int ret = -1;
> > +
> > +       if (!inode || !consumer || consumer->next)
> > +               return -EINVAL;
> > +       uprobe = uprobes_add(inode, offset);
> 
> What happens if uprobes_add() returns NULL?
> 
Right again, I should have added a check to see if uprobes_add
hasnt returned NULL.

-- 
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/