Re: [PATCH v2 2.6.38-rc8-tip 3/20] 3: uprobes: Breakground pagereplacement.

[Steven Rostedt]

On Mon, 2011-03-14 at 22:54 +0530, Srikar Dronamraju wrote:
> > 
> > I'm confused by the above comment and code. You state we are only
> > interested text pages mapped read-only, but then if the page is mapped
> > read/exec we exit out? It is fine if it is anything but READ/EXEC.
> 
> You are right, it should have been
>         if ((vma->vm_flags & (VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)) !=
>                                         (VM_READ|VM_EXEC))
>                 goto put_out;
> 
> 
Golden rule #12: When the comments do not match the code, they probably
are both wrong ;)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/