RE: [PATCH 10/21] Staging: hv: Cleanup root device handling

[KY Srinivasan]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxx]
> Sent: Monday, March 14, 2011 3:59 PM
> To: KY Srinivasan
> Cc: Greg KH; linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx;
> virtualization@xxxxxxxxxxxxxx; Haiyang Zhang; Mike Sterling; Abhishek Kane
> (Mindtree Consulting PVT LTD)
> Subject: Re: [PATCH 10/21] Staging: hv: Cleanup root device handling
> 
> On Mon, Mar 14, 2011 at 07:54:29PM +0000, KY Srinivasan wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH [mailto:greg@xxxxxxxxx]
> > > Sent: Monday, March 14, 2011 3:34 PM
> > > To: KY Srinivasan
> > > Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; Haiyang Zhang;
> Mike
> > > Sterling; Abhishek Kane (Mindtree Consulting PVT LTD)
> > > Subject: Re: [PATCH 10/21] Staging: hv: Cleanup root device handling
> > >
> > > On Thu, Mar 10, 2011 at 02:08:06PM -0800, K. Y. Srinivasan wrote:
> > > > Now we can complete the cleanup of the root device
> > > > management. Use the preferred APIs for creating and
> > > > managing the root device. As part of this cleanup get rid
> > > > of the root device object from vmbus_driver_context.
> > >
> > > I don't understand, what is the "root device"?
> >
> > This would be the device under /sys/devices that all
> > other hyperv devices would be grouped under.
> > This notion of the root device existed in the existing
> > code; however  its creation and management was
> > unnecessarily complicated.
> 
> But that is what your new pci device should be, not a separate one.  Why
> not use that instead?
> 
> Actually, how are things looking then?  You have a pci device, with no
> children, yet the root device has the children devices?  That doesn't
> really make sense now does it?

Good point. I will cleanup the patches and send you the updated ones shortly.

Regards,

K. Y


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/