Re: [RFC-v2 01/12] iscsi: Resolve iscsi_proto.h naming conflictswith drivers/target/iscsi

[Nicholas A. Bellinger]

On Mon, 2011-03-14 at 15:59 +0100, Christoph Hellwig wrote:
> On Mon, Mar 14, 2011 at 04:56:58AM -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> > 
> > This patch renames the following iscsi_proto.h structures to avoid
> > namespace issues with drivers/target/iscsi/iscsi_target_core.h:
> > 
> > *) struct iscsi_cmd -> struct iscsi_scsi_cmd
> 
> This name is not overly descriptive.  Using _req/_rsp uniformly would make a
> lot more sense.
> 

Mmmm, fair point here..  I don't have a strong preference so I will
defer to Mike and Hannes on this (open-iscsi CC'ed).  Guys is this OK
with you..?

Thanks,

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/