Re: [PATCH v2 2.6.38-rc8-tip 7/20] 7: uprobes: store/restoreoriginal instruction.

[Stephen Wilson]

On Tue, Mar 15, 2011 at 09:47:59AM -0400, Steven Rostedt wrote:
> > 	rcu_read_lock()
> > 	if (mm->owner) {
> > 		get_task_struct(mm->owner)
> > 		tsk = mm->owner;
> > 	}
> > 	rcu_read_unlock()
> > 	if (!tsk)
> > 		return ret;
> > 
> > Agree?
> 
> Or:
> 
> 	rcu_read_lock();
> 	tsk = mm->owner;
> 	if (tsk)
> 		get_task_struct(tsk);
> 	rcu_read_unlock();
> 	if (!tsk)
> 		return ret;
> 
> Probably looks cleaner.

Yes, plus we should do "tsk = rcu_dereference(mm->owner);" and wrap the
whole thing in a static uprobes_get_mm_owner() or similar.


-- 
steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/