Re: [PATCH 2/8] drivers/char/random: Split out __get_random_int

[Matt Mackall]

On Sun, 2011-03-13 at 20:57 -0400, George Spelvin wrote:
> The unlocked function is needed for following work.
> No API change.

As I mentioned last time this code was discussed, we're already one
crypto-savvy attacker away from this code becoming a security hole. 
We really need to give it a serious rethink before we make it look
anything like a general-use API. 

And you've got it backwards here: __ should be the unlocked, dangerous
version. But the locked version already has a __ because it's already
dangerous.

-- 
Mathematics is the supreme nostalgia of our time.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/