Re: [PATCH 5/8] mm/slub: Factor out some common code.

[Pekka Enberg]

On Thu, Mar 17, 2011 at 9:07 AM, George Spelvin <linux@xxxxxxxxxxx> wrote:
>> I certainly don't but I'd still like to ask you to change it to
>> 'unsigned long'. That's a Linux kernel idiom and we're not going to
>> change the whole kernel.
>
> Damn, and I just prepared the following patch.  Should I, instead, do
>
> --- a/include/linux/slab_def.h
> +++ b/include/linux/slab_def.h
> @@ -62,5 +62,5 @@ struct kmem_cache {
>  /* 3) touched by every alloc & free from the backend */
>
> -       unsigned int flags;             /* constant flags */
> +       unsigned long flags;            /* constant flags */
>        unsigned int num;               /* # of objs per slab */
>
> ... because the original slab code uses an unsigned int.

Looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/