Re: [PATCH -v3 -resend] watchdog, SP5100: Check if firmware hasset correct value in tcobase.

[Wim Van Sebroeck]

Hi Yinghai,

> Stefano found SP5100 TCO watchdog driver using wrong address.
>
> [    9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
> [    9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 reserved=1
>
> and e820 said that range is RAM.
>
> We should check if we can use that reading out. BIOS could just program wrong address there.
>
> -v2: Mike pointed out one path need one release.
> -v3: corrected logic checking with request_mem_region_exclusive()
>      Found by Konrad.
>
>
> Reported-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Signed-off-by:Yinghai Lu <yinghai@xxxxxxxxxx>
> Acked-by: Mike Waychison <mikew@xxxxxxxxxx>
> Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

This patch is in linux-2.6-watchdog-next for a week now. Will go upstream to linus.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/