[PATCH 2/3] debugfs: move to new usr_strtobool

From: Jonathan Cameron
Date: Thu Mar 24 2011 - 09:22:55 EST


No functional chagnes requires that we eat errors from usr_strtobool.
If people want to not do this, then it should be at a later date.

Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxx>
---
fs/debugfs/file.c | 20 ++++++--------------
1 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index 89d394d..1f0e3ef 100644
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -428,26 +428,18 @@ static ssize_t write_file_bool(struct file *file, const char __user *user_buf,
size_t count, loff_t *ppos)
{
char buf[32];
- int buf_size;
+ int buf_size, ret;
+ bool bv;
u32 *val = file->private_data;

buf_size = min(count, (sizeof(buf)-1));
if (copy_from_user(buf, user_buf, buf_size))
return -EFAULT;

- switch (buf[0]) {
- case 'y':
- case 'Y':
- case '1':
- *val = 1;
- break;
- case 'n':
- case 'N':
- case '0':
- *val = 0;
- break;
- }
-
+ ret = usr_strtobool(buf, &bv);
+ if (!ret)
+ *val = bv;
+
return count;
}

--
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/