Re: check device_create_file() return code inusb_create_sysfs_intf_files()

[Michal Nazarewicz]

On Thu, 24 Mar 2011 15:56:06 +0100, Sergey Senozhatsky wrote:
> diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c
> index 6781c36..d03c630 100644
> --- a/drivers/usb/core/sysfs.c
> +++ b/drivers/usb/core/sysfs.c
> @@ -846,7 +846,7 @@ int usb_create_sysfs_intf_files(struct usb_interface  
> *intf)
>  {
>  	struct usb_device *udev = interface_to_usbdev(intf);
>  	struct usb_host_interface *alt = intf->cur_altsetting;
> -	int retval;
> +	int retval = -1;

That should be 0 or some other meaningful value. A literal -1 is definitely
not a good choice.  This is just for future since Alan has explained this
patch is not needed.

> 	if (intf->sysfs_files_created || intf->unregistering)
>  		return 0;

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/