Re: [RFC PATCHv2 3/4] drivers/otp: allow an ioctl to be specified

[Mike Frysinger]

On Thu, Mar 24, 2011 at 11:21, Jamie Iles wrote:
> Some drivers may need an ioctl method to provide device specific control
> such as blackfin for providing locking. ÂRegions can specify an ioctl to
> be used but this field method is optional.

shouldnt this just be squashed into patch 1 since you havent merged
any of this yet ?

> +static long otp_ioctl(struct file *filp, unsigned cmd, unsigned long arg)
> +{
> + Â Â Â struct otp_region *region = filp->private_data;
> + Â Â Â long ret = -ENOTTY;
> +
> + Â Â Â if (down_interruptible(&otp_sem))
> + Â Â Â Â Â Â Â return -ERESTARTSYS;
> +
> + Â Â Â if (region->ops->ioctl)
> + Â Â Â Â Â Â Â ret = region->ops->ioctl(region, cmd, arg);
> +
> + Â Â Â up(&otp_sem);
> +
> + Â Â Â return ret;
> +}

the existence check can be pulled out of the locking

long ret;

if (!region->ops->ioctl)
    return -ENOTTY;

if (down_interruptible(&otp_sem))

    return -ERESTARTSYS;

ret = region->ops->ioctl(region, cmd, arg);

up(&otp_sem);

return ret;
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/