Re: [patch 1/3] arm/gpio: Remove three copies of broken and racydebug code
From: Thomas Gleixner
Date: Thu Mar 24 2011 - 18:43:24 EST
On Fri, 25 Mar 2011, Ryan Mallon wrote:
> On 03/25/2011 10:27 AM, Thomas Gleixner wrote:
> > gpiolib plus two gpio implementations in arm fiddle in the guts of
> > irq_desc in a racy and buggy way. Remove the stuff. I already told the
> > gpio folks that we can provide that information in a proper way if
> > necessary.
> >
> > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > ---
> > arch/arm/mach-ep93xx/gpio.c | 39 -------------------------------------
> > arch/arm/plat-nomadik/gpio.c | 45 -------------------------------------------
> > drivers/gpio/gpiolib.c | 45 -------------------------------------------
> > 3 files changed, 129 deletions(-)
> >
> > Index: linux-2.6-tip/arch/arm/mach-ep93xx/gpio.c
> > ===================================================================
>
> I suggested an alternative patch for the ep93xx last time round which
> keeps the information that the pin is configured as an interrupt and
> tidies the code a bit (moves the newline to the first seq_printf). My
> patch is available here:
> http://lists-archives.org/linux-kernel/27439434-arm-ep93xx-kill-another-instance-of-broken-irq_desc-fiddling.html
>
> Could we merge that instead please.
Sure. Will pick it up.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/