RE: [PATCH] gpio: ml_ioh_gpio: Fix output value of ioh_gpio_direction_output()

From: Tomoya MORINAGA
Date: Thu Mar 24 2011 - 20:32:03 EST


Hi Peter,

On Friday, March 25, 2011 8:17 AM, Peter Tyser wrote:

> The ioh_gpio_direction_output() function was missing a write
> to set the desired output value. The function would properly
> set the GPIO direction, but not the output value. The value
> would have to manually be set with a follow up call to ioh_gpio_set().

> This is untested - just noticed it while working on an
> unrelated change. An ack or tested-by from someone with real
> hardware would be appreciated.

Thank you for your indication.
Your saying is right.
However since your patch looks incorrect,
after testing, I will post new patch by next week.

Thanks,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/