Re: [PATCH] xen: Use new irq_move functions

From: Ian Campbell
Date: Fri Mar 25 2011 - 06:04:13 EST


On Thu, 2011-03-24 at 20:37 +0000, Thomas Gleixner wrote:
> These functions take irq_data as an argument and avoid a redundant
> lookup in the sparse irq case.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Looks good to me.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Do you want to carry this in your tree or shall we pick it up? (not sure
if this is part of a wider treewide series or not)

> Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
> drivers/xen/events.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6-tip/drivers/xen/events.c
> ===================================================================
> --- linux-2.6-tip.orig/drivers/xen/events.c
> +++ linux-2.6-tip/drivers/xen/events.c
> @@ -585,7 +585,7 @@ static void ack_pirq(struct irq_data *da
> {
> int evtchn = evtchn_from_irq(data->irq);
>
> - move_native_irq(data->irq);
> + irq_move_irq(data);
>
> if (VALID_EVTCHN(evtchn)) {
> mask_evtchn(evtchn);
> @@ -1339,7 +1339,7 @@ static void ack_dynirq(struct irq_data *
> {
> int evtchn = evtchn_from_irq(data->irq);
>
> - move_masked_irq(data->irq);
> + irq_move_masked_irq(data);
>
> if (VALID_EVTCHN(evtchn))
> unmask_evtchn(evtchn);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/