Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gate key

[Corentin Chary]

> +static void eeepc_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âint *value, int *autorelease)
> +{
> + Â Â Â struct eeepc_wmi_driver *eeepc = to_eeepc_wmi_driver(asus_wmi);
> + Â Â Â int is_press;
> +
> + Â Â Â /*
> + Â Â Â Â* The following behavior is used for T101MT "Home" key:
> + Â Â Â Â*
> + Â Â Â Â* Â On press: Â No event set
> + Â Â Â Â* Â On hold: Â ÂKEY_PROG2 press sent once w/o autorelease
> + Â Â Â Â* Â On release: If key was held, KEY_PROG2 release sent.
> + Â Â Â Â* Â Â Â Â Â Â Â Otherwise KEY_HOME press sent w/ autorelease.
> + Â Â Â Â*
> + Â Â Â Â* The simple state machine below implements this behavior.
> + Â Â Â Â*/
> + Â Â Â switch (*code) {
> + Â Â Â case HOME_PRESS:
> + Â Â Â Â Â Â Â eeepc->home_key_state = HOME_PRESS;
> + Â Â Â Â Â Â Â *code = ASUS_WMI_KEY_IGNORE;
> + Â Â Â Â Â Â Â break;
> + Â Â Â case HOME_HOLD:
> + Â Â Â Â Â Â Â if (eeepc->home_key_state == HOME_HOLD) {
> + Â Â Â Â Â Â Â Â Â Â Â *code = ASUS_WMI_KEY_IGNORE;
> + Â Â Â Â Â Â Â } else {
> + Â Â Â Â Â Â Â Â Â Â Â eeepc->home_key_state = HOME_HOLD;
> + Â Â Â Â Â Â Â Â Â Â Â *value = 1;
> + Â Â Â Â Â Â Â Â Â Â Â *autorelease = 0;
> + Â Â Â Â Â Â Â }
> + Â Â Â Â Â Â Â break;
> + Â Â Â case HOME_RELEASE:
> + Â Â Â Â Â Â Â if (eeepc->home_key_state == HOME_RELEASE) {
> + Â Â Â Â Â Â Â Â Â Â Â dev_warn(&asus_wmi->platform_device->dev,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â"Unexpected home key release event\n");
> + Â Â Â Â Â Â Â Â Â Â Â *code = ASUS_WMI_KEY_IGNORE;
> + Â Â Â Â Â Â Â } else {
> + Â Â Â Â Â Â Â Â Â Â Â *code = eeepc->home_key_state;
> + Â Â Â Â Â Â Â Â Â Â Â eeepc->home_key_state = HOME_RELEASE;
> + Â Â Â Â Â Â Â Â Â Â Â is_press = (*code == HOME_PRESS);
> + Â Â Â Â Â Â Â Â Â Â Â *value = is_press;
> + Â Â Â Â Â Â Â Â Â Â Â *autorelease = is_press;
> + Â Â Â Â Â Â Â }
> + Â Â Â Â Â Â Â break;
> + Â Â Â }
> +}
> +

Why not something simpler like this ?

static void eeepc_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int code,
                  Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âint *value, int *autorelease)
{
        if (code == 0xe4) {
                *value = 1;
                *autorelease = 0;
        } else if (code == 0xe5) {
                *value = 0;
                *autorelease = 0;
       }
}

with this keymap :

       { KE_KEY, 0xe4, { KEY_HOME } }, /* Home Key Down */
       { KE_KEY, 0xe5, { KEY_HOME } }, /* Home Key Up */
       { KE_KEY, 0xea, { KEY_PROG2 } }, /* Home Key hold more than one second */


This sounds simpler and we don't loose information (key down and key
up both event reported at the right time).
0xe5 is *always* sent after 0xe4 right ?

Also, for the callback, "value" should be an unsigned int, and
"autorelease" a bool.

Thanks,
-- 
Corentin Chary
http://xf.iksaif.net
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðÃnÆàþY&—