Re: [tip:core/urgent] WARN_ON_SMP(): Allow use in if() statements onUP

From: Alexey Dobriyan
Date: Fri Mar 25 2011 - 15:47:45 EST


On Fri, Mar 25, 2011 at 03:40:34PM -0400, Steven Rostedt wrote:
> On Fri, 2011-03-25 at 21:31 +0200, Alexey Dobriyan wrote:
>
> > > Would you like me to add a comment that states:
> > >
> > > /*
> > > * Use ({0;}) as just "0" will cause gcc to output:
> > > * warning: statement with no effect
> > > */
> >
> > Try ((void)0)
>
> Maybe I should update the comment to stop further confusion:

Ah!

I always thought if (WARN_ON(x)) is confusing and should be banned.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/