Re: [PATCH 2.6.38.1] pata_it821x: Add module param to force UDMA onVortex86SX

[Alan Cox]

>  May be there are errors with pure IDE devices or with older revisions 
>  of Vortex86SX
>  boards, i do no know. But for my device i have 2x improvement in I/O 
>  speed when
>  enabling UDMA/33 instead of MWDMA, so i think this parameter would be 
>  useful.

"I do not know" is not a good basis for hacking storage code,
particularly if it was to turn out that the reason was something like
silent data corruption (eg as with UDMA on the old OSB4 controllers in
some cases)

The change came via DMP signoff (the manufacturer) so any adjustment of
this sort of checking really ought to go via DMP as well.

>  Also fix to initialize default value for parameter 'noraid'.

This does not need initialising - C guarantees static variables start at
zero. If that makes a difference you have other problems.

So NAK this.

Although if you want to take it up with DMP and find out if they have
updated rules or checks that want pushing that might be useful.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/