Re: [GIT PULL] Core block IO bits for 2.6.39

From: Linus Torvalds
Date: Sat Mar 26 2011 - 12:49:24 EST


On Fri, Mar 25, 2011 at 11:29 PM, Jens Axboe <jaxboe@xxxxxxxxxxxx> wrote:
> +
> +       /* Use 3ms as that was the old plug delay */
> +       blk_delay_queue(q, msecs_to_jiffies(3));

That's bogus. blk_delay_queue() already takes msecs, not jiffies.

Also, do we really need to delay every unplug like this? It seems sad.
A 3ms delay is a long time these days - admittedly most people
hopefully use ATA these days if they have an SSD or something, but
still..

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/