Re: [RFC PATCHv2 1/4] drivers/otp: add initial support for OTP memory

[Mike Frysinger]

On Sat, Mar 26, 2011 at 06:54, Arnd Bergmann wrote:
> On Saturday 26 March 2011 03:16:48 Mike Frysinger wrote:
>> On Fri, Mar 25, 2011 at 20:21, Jamie Iles wrote:
>> > For the actual ioctl() we should assume byte addressing rather than
>> > words though and do the conversion in the driver so we can cope with
>> > devices that don't have 64-bit words and do the locking on a looping
>> > word-by-word basis.
>> >
>> > Â Â Â Âstruct otp_lock_req {
>> > Â Â Â Â Â Â Â Â__u32 Â start_addr;
>> > Â Â Â Â Â Â Â Â__u32 Â byte_count;
>> > Â Â Â Â};
>
> Looks good to me.
>
>> i would add an ABI field here too so if in the future we want to add
>> stuff, we can do so without adding new ioctls. Âlike "u16 version; u16
>> flags;". Âthen in the ioctl, if version isnt 0, we return ENOTSUP. Âin
>> the future, we can add flags or bump the version.
>
> No, versioned APIs are just a pain to maintain, it's easier to add
> new ioctl commands when necessary.
> Note that the kernel would always have to support all versions of
> the API anyway.

adding at least a flags field then should be fine
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/